ci(asan): build boost_sentinel so it runs (fixes linux-asan Not Run -> exit 8)#714
Merged
Merged
Conversation
The linux-asan job registers the boost_sentinel test (root CMake add_subdirectory(ci/sentinel) under GTest_FOUND) but its --target allowlist never built the boost_sentinel binary. ctest --exclude-regex "LiveTest\." then finds the registered test, cannot find the executable, and reports it Not Run -> ctest exit 8. Deterministic on every ASan run since #700 added the sentinel wired only to the linux lane; surfaced as a red on unrelated PRs (#713 web-only, #706 DASH S8). Add boost_sentinel to the ASan build target list so the binary exists and the sentinel actually runs under ASan/UBSan (bonus: sanitized coverage of the boost integrity gate). Mirrors the linux lane, which builds the target via its dedicated Boost sentinel step.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Linux x86_64 (AsAN+UBSan)fails with:Every real test passes; only
boost_sentinelshows Not Run, tripping ctest exit 8. Reported on #713 (web-only) and #706 (DASH S8).Root cause (deterministic, not a flake)
add_subdirectory(ci/sentinel)underGTest_FOUND->add_test(NAME boost_sentinel ...).Build c2pool + tests--targetallowlist never built theboost_sentinelbinary.ctest --exclude-regex "LiveTest\."includes the registered test but the executable is absent -> Not Run -> exit 8.linuxlane (its dedicated Boost sentinel step). The ASan lane is informational/non-gating (build.yml L169), so master stayed green while the lane was silently red on every ASan run since.Fix
Add
boost_sentinelto the linux-asan build target list so the binary exists and the sentinel runs under ASan/UBSan (bonus: sanitized coverage of the boost integrity gate). One-line diff; mirrors the linux lane intent.Unblock path for #713 / #706
This fix lives in build.yml on master. After merge (operator push-approval), rebase #713 and #706 onto new master to pick it up; their ASan lanes then go green. I can alternatively cherry-pick this one-liner onto each branch for a faster unblock.
No self-merge.